Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use named environments (only "default" for now) #674

Merged
merged 4 commits into from
Jan 17, 2024
Merged

feat: use named environments (only "default" for now) #674

merged 4 commits into from
Jan 17, 2024

Conversation

ruben-arts
Copy link
Contributor

Now the environments would be put in:

pixi/.pixi
└── envs
    └── default
        ├── bin
        ├── ...
        └── prefix  <--- prefix file

@wolfv
Copy link
Member

wolfv commented Jan 17, 2024

I like the change but do we have to think about a migration strategy for existing users / envs?

@wolfv wolfv merged commit d2b884a into prefix-dev:main Jan 17, 2024
9 checks passed
@pavelzw
Copy link
Contributor

pavelzw commented Jan 18, 2024 •
edited
Loading

This will probably also lead to similar problems as prefix-dev/setup-pixi#66 and prefix-dev/setup-pixi#35 in CI (or at least always deprecation warnings when the old cache is used and never discarded)

@wolfv
Copy link
Member

wolfv commented Jan 18, 2024

@pavelzw should we make the pixi version part of the cache key? Could that help?

@pavelzw
Copy link
Contributor

pavelzw commented Jan 18, 2024

Yeah that would help although latest is not really ideal for caching... we could either get the output of pixi --version or just use the SHA if the downloaded binary

@pavelzw
Copy link
Contributor

pavelzw commented Jan 18, 2024

prefix-dev/setup-pixi#67

@ruben-arts ruben-arts added this to the Multi-env milestone Jan 25, 2024
@zuisong zuisong mentioned this pull request Feb 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baszalmstra baszalmstra baszalmstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Multiple environment support in `pixi`
Status: Done
Milestone
Multi-env
Development

Successfully merging this pull request may close these issues.
4 participants
@ruben-arts @wolfv @pavelzw @baszalmstra